Bbs plus correction and add multi message signing/verifying#18
Open
rkxx wants to merge 5 commits intodanubetech:mainfrom
Open
Bbs plus correction and add multi message signing/verifying#18rkxx wants to merge 5 commits intodanubetech:mainfrom
rkxx wants to merge 5 commits intodanubetech:mainfrom
Conversation
Member
|
Hello, in general looks good, but similar to my other comment here decentralized-identity/jsonld-common-java#11 (review), could we not add Kotlin things? Sorry about that :( |
|
|
Author
|
Have removed kotlin and kotlin unit tests. |
Member
|
Thanks, please see the Contributor License Agreement (CLA) above, so we can accept the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes in the pom file are required to run the unit tests (kotlin). Feel free to only merge the source changes and keep the project pure java.
The PrivateKeySigner derived from the ByteSigner only allows signing a single ByteArray. The BBSPlus_PrivateKeySigner extends the PrivateKeySigner by a method for signing a List of ByteArrays. This is required to use this library to create ld-signatures by signing a list of digested statements.