Closed
Conversation
|
Dappnode bot has built and pinned the built packages to an IPFS node, for commit: b1ecd15 This is a development version and should only be installed for testing purposes.
Hash: (by dappnodebot/build-action) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the asset inlining process in
ui_openvpn/injectToHtml.jsby introducing a utility for determining MIME types and adding support for inlining media assets (such as images) directly into the HTML as data URIs. This improves portability and reduces external asset dependencies in the generated HTML.Media asset inlining improvements:
getMimeTypefunction to determine the correct MIME type for various image and icon file extensions, ensuring proper data URI formatting when inlining assets.static/mediadirectory by replacing references in the HTML with their corresponding base64-encoded data URIs, making the HTML self-contained.