MAINT: don't import helpers in numpy namespace#327
Merged
ev-br merged 2 commits intodata-apis:mainfrom May 15, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes unintended helper imports from the numpy namespace to align with recent changes.
- Removed the wildcard import from common helpers.
- Replaced an import from .linalg with a corrected version using type ignore comments.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
ev-br
approved these changes
May 15, 2025
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#288 accidentally re-added lines (I assume after a bad merge from main) that were recently deleted in #302.
@ev-br it would be good to have this in the release.