Add e2e test for ingestion pipeline

[vish-cs]

This PR adds a new E2E test which runs the import workflow (batch job) + ingestion workflow (dataflow) and verifies data in spanner. This is used to promote the pipeline from staging to prod as part of cloud build.

[gemini-code-assist]

Summary of Changes

Hello @vish-cs, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a crucial end-to-end test for the ingestion pipeline, ensuring the seamless flow and correct processing of data from import automation through to its final storage and verification in Spanner. It establishes a robust testing framework by adding a new Cloud Build configuration for staging, a Python utility for workflow management, and the necessary Spanner schema definitions.

Highlights

• End-to-End Test: Added a comprehensive end-to-end (E2E) test to validate the entire ingestion pipeline, from import automation to Spanner data verification.
• Cloud Workflow Utility: Introduced a new Python utility (cloud_workflow.py) to programmatically trigger and monitor Google Cloud Workflows.
• Staging Cloud Build Configuration: Created a dedicated Cloud Build configuration (cloudbuild_staging.yaml) for staging environments, which deploys necessary workflows and executes the E2E test.
• Spanner Schema Definition: Defined the required Spanner database schema (spanner_schema.sql) for tracking import status and ingestion history.

Changelog

• import-automation/executor/app/executor/cloud_workflow.py
  • Added a new module containing a utility function to trigger and wait for Google Cloud Workflows to complete.
• import-automation/executor/verify_import.py
  • Removed unused datetime and pytz imports.
• import-automation/workflow/cloudbuild.yaml
  • Updated comments to reflect a change in the build project ID.
  • Commented out dir attributes for several workflow and function deployment steps.
  • Commented out existing deployment steps and added new commented sections for staging and production deployments, indicating a refactoring of the Cloud Build process.
• import-automation/workflow/cloudbuild_staging.yaml
  • Added a new Cloud Build configuration specifically for staging environments, which deploys core ingestion workflows and includes an E2E test step.
• import-automation/workflow/spanner_schema.sql
  • Added a new SQL file defining the schema for ImportStatus, IngestionHistory, ImportVersionHistory, and IngestionLock tables in Spanner.
• import-automation/workflow/verify_ingestion.py
  • Added the main Python script for the end-to-end ingestion pipeline test, which orchestrates workflow execution, verifies data in Spanner, and performs cleanup.

Activity

• The pull request was created by vish-cs to add an end-to-end test for the ingestion pipeline.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds an end-to-end test for the ingestion pipeline, which is a valuable addition for ensuring reliability. The changes include a new staging Cloud Build configuration, a Spanner schema for testing, the test script itself, and a utility for interacting with Cloud Workflows. My review identified critical issues in the cloudbuild.yaml and cloudbuild_staging.yaml files where the dir attribute for build steps is either missing or commented out. These issues will likely cause the builds to fail because they won't be able to locate necessary source files. I have also provided a minor suggestion to improve the test script's adherence to Python best practices.