Open
Conversation
Also attempt to catch + output `browser.OpenFile`'s error. See davecheney#3
Author
|
I ended up making other changes. I'm pushing to my master, so they'll also show up here (sorry, i should've made a feature branch). This PR was originally just for 6b839b7...360d2cc Feel free to totally ignore them, they move this into a bit of a different direction. Look: http://bl.ocks.org/jbenet/c51cd7eb730d18e5cdc2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

@davecheney thanks for making this!
this PR adds:
browserflag to open in browser (currently defaults to false, which is TRTTD, but defaulting to true would match the current functionality, which is backwards compatible and doesn't break people's scripts).❤️ @jbenet