Re-abstracts where we grab data when it's access should be limited to the main thread#20
Open
Re-abstracts where we grab data when it's access should be limited to the main thread#20
Conversation
alloy
reviewed
Jun 27, 2018
alloy
left a comment
alloy
left a comment
There was a problem hiding this comment.
I’m not completely following what is happening. Is the issue that self.bounds may not be accessed from a background thread?
The use of the ivar and its name is also confusing, as it’s not being accessed in a thread safe manner.
|
|
||
| - (void)setFrame:(CGRect)frame | ||
| { | ||
| [super setBounds:frame]; |
There was a problem hiding this comment.
This seems to be invoking the wrong super class’ method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had a meeting get cancelled, so I used my free hour to try and address #19
After this there are issues running the demo app. Alas, I haven't got tests running yet though, been a bunch of Xcode updates in the last 4 years :D
Will come back for the tests sometime
/cc @alloy @dblock