Change over to map setters for entities endpoints#325
Draft
Conversation
dcfca5b to
70d2740
Compare
6c0ec32 to
e67aed4
Compare
…fix parameter name typos AbstractDirectoryExternalModel was missing @SuperBuilder, @NoArgsConstructor, and @AllArgsConstructor, which broke compilation in all modules that use its subclasses. Also fix copy-paste parameter name typos (linksModelModels, applicationsModelModels) in ApplicationLinkResource and ApplicationResource interfaces. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
e67aed4 to
c8f83b8
Compare
Change groups and users fields in DirectoryInternalModel from List<GroupModel>/List<UserModel> to Map<String, GroupModel>/Map<String, UserModel>, keyed by group name and username respectively. This enables per-entity updates via the directory structure, consistent with the map-based endpoint pattern used throughout the branch. - Remove List-based setUsers overload from UsersService interface - Implement Map-based setUsers in Crowd UsersServiceImpl - Convert GroupsService.setGroups from List to Map - Update GroupsResource, DirectoriesServiceImpl.handleGroupsAndUsers, and all related tests Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


No description provided.