Skip to content

Comments

Change over to map setters for entities endpoints#325

Draft
pathob wants to merge 6 commits intomainfrom
map-endpoints
Draft

Change over to map setters for entities endpoints#325
pathob wants to merge 6 commits intomainfrom
map-endpoints

Conversation

@pathob
Copy link
Contributor

@pathob pathob commented Jul 8, 2025

No description provided.

@pathob pathob force-pushed the map-endpoints branch 5 times, most recently from dcfca5b to 70d2740 Compare July 14, 2025 18:01
@pathob pathob force-pushed the map-endpoints branch 2 times, most recently from 6c0ec32 to e67aed4 Compare February 22, 2026 08:08
pathob and others added 5 commits February 22, 2026 18:16
…fix parameter name typos

AbstractDirectoryExternalModel was missing @SuperBuilder, @NoArgsConstructor, and
@AllArgsConstructor, which broke compilation in all modules that use its subclasses.
Also fix copy-paste parameter name typos (linksModelModels, applicationsModelModels)
in ApplicationLinkResource and ApplicationResource interfaces.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@deftdevs deftdevs deleted a comment from sonarqubecloud bot Feb 22, 2026
Change groups and users fields in DirectoryInternalModel from
List<GroupModel>/List<UserModel> to Map<String, GroupModel>/Map<String, UserModel>,
keyed by group name and username respectively. This enables per-entity
updates via the directory structure, consistent with the map-based
endpoint pattern used throughout the branch.

- Remove List-based setUsers overload from UsersService interface
- Implement Map-based setUsers in Crowd UsersServiceImpl
- Convert GroupsService.setGroups from List to Map
- Update GroupsResource, DirectoriesServiceImpl.handleGroupsAndUsers,
  and all related tests

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
17.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant