fix: restore copy icon visibility on code block hover#2944
Merged
Conversation
The SVG path fill was using `hsla(var(--foreground-secondary))` which references a CSS variable that doesn't exist in Tailwind v4 — the correct variable is `--color-foreground-secondary`. This made the copy icon invisible while the button itself was still present and clickable. Changed the fill to `currentColor` so the icon inherits the correct color from the button's `text-foreground-secondary` CSS class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fill="hsla(var(--foreground-secondary))", referencing a CSS variable (--foreground-secondary) that doesn't exist in Tailwind v4 — the correct variable name is--color-foreground-secondaryfilltocurrentColorso the icon inherits the correct color from the button's existingtext-foreground-secondaryCSS classTest plan