Added BUILDKIT_INLINE_CACHE for containerFeature path#1135
Merged
abdurriq merged 2 commits intodevcontainers:mainfrom Feb 3, 2026
Merged
Added BUILDKIT_INLINE_CACHE for containerFeature path#1135abdurriq merged 2 commits intodevcontainers:mainfrom
abdurriq merged 2 commits intodevcontainers:mainfrom
Conversation
Collaborator
|
This is great - I've had various cases where https://github.com/devcontainers/ci/ didn't seem to be caching and I think they would fall into the case that this PR addresses <3 |
Contributor
Author
|
@chrmarti - I dont have permissions to merge - would you be able to? |
abdurriq
requested changes
Feb 2, 2026
Contributor
abdurriq
left a comment
abdurriq
left a comment
There was a problem hiding this comment.
Changes LGTM, but I think tests would help here. Could you please add some tests (unit, at least) to verify the behaviour?
Contributor
Author
abdurriq
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1134
Implement support for the
BUILDKIT_INLINE_CACHEbuild argument when the buildx cache is not set to inline. This change enhances the container build process by ensuring the inline cache is utilized appropriately.BUILDKIT_INLINE_CACHEwas not being set when usingIt also conflicts if you define
cacheTo: type=inline