feat: add Adapter retrieve_peripherals method#448
Open
szymonlesisz wants to merge 1 commit intodeviceplug:devfrom
Open
feat: add Adapter retrieve_peripherals method#448szymonlesisz wants to merge 1 commit intodeviceplug:devfrom
retrieve_peripherals method#448szymonlesisz wants to merge 1 commit intodeviceplug:devfrom
Conversation
szymonlesisz
force-pushed
the
feat/retrieve-peripherals
branch
from
2f50e06 to
4342771
Compare
szymonlesisz
commented
Oct 23, 2025
| &self, | ||
| options: RetrievePeripheralsOptions, | ||
| ) -> Result<Vec<Peripheral>> { | ||
| Err(Error::NotSupported("Not implemented".to_string())) |
Contributor
Author
There was a problem hiding this comment.
maybe instead of throwing i should return an empty vec ? and only log/warn about missing implementation?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is empty prerequisite for:
List of platforms where the method could be implemented
im not familiar with
droidplugbut im sure it is also possible to implement if needed.