docs: Add skills for OISY Wallet Signer#16
Conversation
| --- | ||
| id: oisy-wallet-signer | ||
| name: OISY Wallet Signer | ||
| category: Wallet |
There was a problem hiding this comment.
Maybe there is a predefined list of categories?
| ## What This Is | ||
|
|
||
| A TypeScript library that enables secure communication between dApps and wallets on the Internet Computer using JSON-RPC 2.0 over `window.postMessage`. The signer model = **explicit per-action approval**. `connect()` establishes a channel. Nothing more. | ||
|
|
||
| **It is not:** | ||
|
|
||
| - A session system | ||
| - A delegated identity (no ICRC-34) | ||
| - A background executor | ||
|
|
||
| **ICRC standards implemented:** | ||
|
|
||
| - ICRC-21 — Canister call consent messages | ||
| - ICRC-25 — Signer interaction standard (permissions) | ||
| - ICRC-27 — Accounts | ||
| - ICRC-29 — Window PostMessage transport | ||
| - ICRC-49 — Call canister | ||
|
|
||
| **Not yet implemented:** | ||
|
|
||
| - ICRC-46 — Session-based delegation (not supported; use a delegation-capable model if you need sessions) | ||
|
|
There was a problem hiding this comment.
too long? the guidelines say 2-3 sentences...
| }); | ||
| ``` | ||
|
|
||
| #### IcrcWallet — Any ICRC Ledger |
There was a problem hiding this comment.
maybe here not ANY ICRC ledger but "SUPPORTED ICRC as explained before"
| | Denied | `ICRC25_PERMISSION_DENIED` | Rejected immediately (error 3000) | | ||
| | Ask on use | `ICRC25_PERMISSION_ASK_ON_USE` | Prompts user on access (default) | | ||
|
|
||
| Permissions stored in `localStorage` as `oisy_signer_{origin}_{owner}` with timestamps. Default validity: 7 days. |
There was a problem hiding this comment.
is the validity correct? shall we specify if customizable or not?
| name: OISY Wallet Signer | ||
| category: Wallet | ||
| description: Guides integration with @dfinity/oisy-wallet-signer for building dApps (relying party) and wallet UIs (signer) on the Internet Computer using ICRC-21/25/27/29/49 standards. Load when the user mentions wallet signer, relying party, consent messages, token transfers via signer, or canister call signing. | ||
| version: 4.1.0 |
There was a problem hiding this comment.
we need the app version or the "skill" version?
| version: 4.1.0 | ||
| endpoints: 5 | ||
| status: stable | ||
| dependencies: ["@dfinity/utils", "@dfinity/zod-schemas", "@icp-sdk/canisters", "@icp-sdk/core", "zod"] |
There was a problem hiding this comment.
here maybe we are talking about skills dependencies?
|
|
||
| # OISY Wallet Signer | ||
|
|
||
| > version: 4.1.0 | requires: [@dfinity/utils >= 4.1, @dfinity/zod-schemas >= 3, @icp-sdk/canisters >= 3.2, @icp-sdk/core >= 5, zod >= 4] |
There was a problem hiding this comment.
we need the app version or the "skill" version? and maybe we are talking about skills dependencies?
JoshDFN
left a comment
JoshDFN
left a comment
There was a problem hiding this comment.
Looks good — solid skill file. Note: the dependencies field lists npm packages but should list skill IDs (other skills in this repo). The npm deps belong in a requires frontmatter field instead. Also category: Wallet isn't in the current category list — may need to pick an existing one or we add it. Minor stuff, happy to merge once you take it out of draft.
|
Hey Antonio — approved! One small thing: the dependencies: []
requires: [@dfinity/utils >= 4.1, @dfinity/zod-schemas >= 3, @icp-sdk/canisters >= 3.2, @icp-sdk/core >= 5, zod >= 4]Ready to merge once you fix that and take it out of draft! |
skills/oisy-wallet-signer/SKILL.md
Outdated
| - ICRC-29 — Window PostMessage transport | ||
| - ICRC-49 — Call canister | ||
|
|
||
| **Not yet implemented:** |
4 participants
Adding the
SKILL.mdfile for the repo OISY Wallet Signer.Credits: @artkorotkikh-dfinity