Open
Conversation
Contributor
Author
|
The Trunk Code Quality check complains about formatting in the compose files. I don't have trunk installed. Can a maintainer take a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In c4bb411 there was an effort to replace net/trace with spans from OpenCensus. A few remnants of net/trace still remain, this PR removes them.
The trace package exposes two endpoints:
/debug/requestsand/debug/events. They contain some incomplete data regarding raft indexes and schema loading. The documentation also does not refer to the endpoints or the event log at all.The documentation however incorrectly refers to the flag
expose_trace(https://docs.dgraph.io/learn/howto/retrieving-debug-information#metrics-information), that is meant for the event log, but describes the flag as controlling the/debug/varsendpoint.This PR does the following:
expose_traceflag from code and docker compose filesRegardless of this PR, the documentation should be updated to not associate the
expose_traceconfig option with the/debug/varsendpoint