refactor: New cli for labpdfproc#207
Closed
cadenmyers13 wants to merge 37 commits intodiffpy:mainfrom
Closed
Conversation
…d with _create_args
Contributor
Author
|
@sbillinge This is ready for review/discussion if you find some time this weekend. Im marking this as a draft for now so i can come back monday with a clearer head. Also the merge conflict looks to be because of some re-skpkging work. Just wanted to get this to you if you have any comments. |
Contributor
|
I looked through the commands and they look great. I like everything you did here. |
Contributor
Author
|
Closing because of merge conflicts. Couldn't figure out how to resolve them and didn't want to lose everything |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to get this PR in before the weekend, so apologies for the sloppy commits. This PR improves the UX of labpdfproc. It breaks it into 3 subcommands
mud,zscan, andsample. These commands do the followingmudcommandzscancommandsamplecommandAll commands have the same following options
Additional changes
--anode-typeand merged it with--wavelength. If the user wants to specify an anode type, they still can. They just use the--wavelengthoption (ie--wavelength Mo) and the code recognizes this. I felt as if this made the code smoother.Gooey interface
With this change, the gui now is separated nicely into its three subcommands.
