refactor: apply_interpolation_matrix() is now compute_stretched_components()#171
Merged
sbillinge merged 5 commits intodiffpy:john-developmentfrom Aug 25, 2025
Merged
Conversation
added 5 commits
August 23, 2025 21:58
…() and remove legacy MATLAB terminology
Contributor
|
merging to keep this going, but can we think about a test for this function? some very small matrix? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original apply_interpolation_matrix() was kind of a mess. The core logic, which is honestly not that complicated, was buried under a sea of indexing and biasing hacks, many of which were unnecessary mimicry of the data format of the original MATLAB code.
It should be hopefully now be clear that this function:
To fit this theme of simplicity, the function has been renamed to better match what it is used for.