docs: add the instruction to reinstall pycifrw#145
docs: add the instruction to reinstall pycifrw#145ycexiao wants to merge 1 commit intodiffpy:mainfrom
pycifrw#145Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #145 +/- ##
=======================================
Coverage 98.93% 98.93%
=======================================
Files 13 13
Lines 1878 1878
=======================================
Hits 1858 1858
Misses 20 20 🚀 New features to boost your workflow:
|
|
@sbillinge, it's ready for review. |
sbillinge
left a comment
sbillinge
left a comment
There was a problem hiding this comment.
this is good, but please see my comments
|
|
||
| pip install . | ||
|
|
||
| In ``diffpy.structure>=3.3.1``, please ensure the dependency ``pycifrw`` is installed from ``conda-froge`` :: |
There was a problem hiding this comment.
Please do a bit more checking. Are the PyPI and conda version numbers the same? if not, then it could be a version number issue. and the instructions would be to install pycifrw>=??? or pycifrw<=??. If the version is the same on PyPI and conda-forge, let the users know that explicitly (the conda-forge one works but the PyPI one doesn't).
We can also check to see if we can update our tests so it passes with both versions too.
Let's discuss it, but we can also propose to make an issue/PR at pycifrw.
|
closed as not needed. Closed by the fix in #146 |
|
closed as not needed. Closed by the fix in #146 |
2 participants
What problem does this PR address
Adding the instruction to reinstall
pycifrwas mentioned in #144What should the reviewer(s) do
Please check the modified
README.rst