Skip to content

Conversation

@cadenmyers13
Copy link
Contributor

this was printing a bad docstring because we didnt handle the None case. it printed like this,

This function has been deprecated and will be removed in version 4.0.0.
Please use None.new_func instead.

Now, if new_base=None, the print statement will look like

This function has been deprecated and will be removed in version 4.0.0.
Please use new_func instead.

optionally, we can make the user always specify a base.

@cadenmyers13
Copy link
Contributor Author

cadenmyers13 commented Feb 4, 2026

@sbillinge ready for review. The docstring print function didnt handle the None case nicely. Let me know what you think here

@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (6ab0068) to head (fdca183).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #380   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          567       567           
=========================================
  Hits           567       567           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sbillinge sbillinge merged commit 5239628 into diffpy:main Feb 4, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants