Skip to content

Add navigation docker build workflow#1259

Open
spomichter wants to merge 5 commits intodevfrom
chore/add-navigation-docker-workflow
Open

Add navigation docker build workflow#1259
spomichter wants to merge 5 commits intodevfrom
chore/add-navigation-docker-workflow

Conversation

@spomichter
Copy link
Contributor

Summary

  • build and push the navigation docker image to GHCR on changes in docker/navigation

Testing

  • not run (workflow change only)

@greptile-apps
Copy link

greptile-apps bot commented Feb 14, 2026

Greptile Overview

Greptile Summary

Adds a new GitHub Actions workflow job to build and push the navigation Docker image to GHCR. The job follows the existing pattern used by other image builds in the workflow, using the reusable _docker-build-template.yml workflow. It triggers on changes to docker/navigation/** files and builds from the osrf/ros:humble-desktop-full base image.

  • Added navigation output to the check-changes job to track changes in docker/navigation/**
  • Created navigation job that builds and pushes to ghcr.io/dimensionalos/navigation:{branch-tag}
  • Job configuration matches pattern used by other standalone builds (dev, python, ros)
  • Uses osrf/ros:humble-desktop-full as base image, which aligns with the navigation Dockerfile

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The changes follow the exact pattern established by other docker build jobs in the workflow (ros, python, dev). The path filter, output declaration, and job configuration are all consistent with existing implementations. No dependencies on other jobs means it won't disrupt existing workflows. The referenced dockerfile and directory exist in the repository.
  • No files require special attention

Important Files Changed

Filename Overview
.github/workflows/docker.yml Added navigation docker build job with path filtering for docker/navigation/**

Flowchart

flowchart TD
    A[Push to main/dev or PR] --> B[check-changes job]
    B --> C{Changed files filter}
    C -->|docker/navigation/** changed| D[navigation output = true]
    C -->|docker/ros/** changed| E[ros output = true]
    C -->|docker/python/** changed| F[python output = true]
    C -->|docker/dev/** changed| G[dev output = true]
    
    D --> H[navigation job]
    H --> I[_docker-build-template.yml]
    I --> J[Build from osrf/ros:humble-desktop-full]
    J --> K[Push to ghcr.io/dimensionalos/navigation:branch-tag]
    
    E --> L[ros job]
    F --> M[python job]
    G --> N[dev job]
    
    style H fill:#90EE90
    style D fill:#90EE90
    style K fill:#90EE90
Loading

Last reviewed commit: b20bcba

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant