Revert PR #96 GC startup changes#155
Merged
SudoPlz merged 1 commit intodiscord:0.81.4-discordfrom Mar 4, 2026
Merged
Conversation
This reverts commit 491af54.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts the "Avoid GC during the app start" change (originally from #96) on 0.81.4-discord by reverting commit 491af54.
The reason we're doing that was because despite our initial tests, where we tested the benefits of this optimization (which is TTI improvement) - were memory did not increase, it turns out in current tests that memory does regress a bit.
Specifically on my device tests I noticed a 48MB regression in memory 30s after app start and 137ms TTI improvement
This is not to be discarded for ever. We'll dig deeper into this, figure out why the regression is happening and find a way to only grab the benefit (TTI improvement) out of this without regressions.