feat/3187 add engine args sqlalchemy source and destination #3414
+367
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
docs | cbf342d | Commit Preview URL Branch Preview URL |
Jan 06 2026, 02:52 PM |
rudolfix
reviewed
Dec 2, 2025
Collaborator
rudolfix
left a comment
rudolfix
left a comment
There was a problem hiding this comment.
this is really good! let's look at existing test fixtures tomorrow
| return engine_.connect() | ||
|
|
||
| def return_conn(self, borrowed_conn: "Connection") -> None: | ||
| if getattr(self, "_conn_owner", None) is False: |
Collaborator
There was a problem hiding this comment.
it looks like passing external engine here never worked before... we need to test it well
Contributor
Author
There was a problem hiding this comment.
i added that passsing built engine is not disposed after use
dlt/sources/sql_database/__init__.py
Outdated
| engine_kwargs = engine_kwargs or {} | ||
| engine = engine_from_credentials( | ||
| credentials, | ||
| False, |
Collaborator
There was a problem hiding this comment.
would be good to pass may_dispose_after_use here
| table_name="inmemory_table" | ||
| ) | ||
|
|
||
| assert_load_info(info) |
Collaborator
There was a problem hiding this comment.
I'd check if engine is not disposed after use in the pipeline
|
|
||
| def test_engine_kwargs_timeout_is_honored_sqlite(): | ||
| """SQLite timeout in engine_kwargs must be honored.""" | ||
| fd, db_path = tempfile.mkstemp(suffix=".db") |
Collaborator
There was a problem hiding this comment.
we have a test storage which is automatically cleared.
tetelio
force-pushed
the
feat/3187-add-engine-args-sqlalchemy-source-and-destination
branch
from
f6bf24a to
3a137ba
Compare
Fix documentation for inmemory sqlite destination and add test for it.
file based database.
…tests. There will be only sqlite and mysql
files for windows and linux (passes for macos)
…vs external engines
tetelio
force-pushed
the
feat/3187-add-engine-args-sqlalchemy-source-and-destination
branch
from
5efbc8a to
7dc1520
Compare
tetelio
force-pushed
the
feat/3187-add-engine-args-sqlalchemy-source-and-destination
branch
from
ed30b66 to
d168f45
Compare
tetelio
force-pushed
the
feat/3187-add-engine-args-sqlalchemy-source-and-destination
branch
from
3e4243a to
cbf342d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
dlt users want to pass SQLAlchemy engine arguments for:
Summary of Changes
This PR introduces support for configuring SQLAlchemy engine arguments across both sources and destinations, addressing a long-standing usability gap:
Sources (
sql_database,sql_table)engine_kwargs, forwarded directly tosqlalchemy.create_engine().Destination (SQLAlchemy)
engine_args.engine_args.Documentation
engine_kwargs.engine_args.Question: To reduce user confusion, should the source parameter be named
engine_kwargs(current) or unified asengine_args(matching the destination)?Related Issues