Updated glob sorting to sort files in parent directories ahead of files in sub-directories.#195
Open
liehann wants to merge 1 commit intodocumentcloud:masterfrom
Open
Updated glob sorting to sort files in parent directories ahead of files in sub-directories.#195liehann wants to merge 1 commit intodocumentcloud:masterfrom
liehann wants to merge 1 commit intodocumentcloud:masterfrom
Conversation
files in subdirectories. eg: /a/b.js /a/a/a.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously Dir[].sort was called, which would result in the following sort order:
/a/a/a.js
/a/b.js
The patch changes the sort order to the following:
/a/b.js
/a/a/a.js
My motivation for the patch was having the following structure:
views/views.js
views/model/action.js
view.js defined a views namespace. action.js used it. Of course there are other ways to fix this, but the updated sort order seemed to make sense anyway.
I added one test to test the behaviour.