Conversation
GammaGames
commented
Mar 24, 2023
GammaGames
commented
Mar 24, 2023
jgonggrijp
requested changes
Mar 24, 2023
Contributor
jgonggrijp
left a comment
jgonggrijp
left a comment
There was a problem hiding this comment.
Thanks! In #254 (comment) you asked whether util.strings was the right place. I don't have strong opinions on the matter, but it seems like this function might feel more at home in function.predicates.
jgonggrijp
approved these changes
Mar 28, 2023
Contributor
|
Ugh, the CI fails because of a linter rule: it doesn't like Can you reproduce this locally, and if so, could you try to fix it? If changing the expression to Otherwise, I will try to fiddle with it sometime soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #254