Conversation
…vigation (#34648) The createFullURL function was incorrectly removing the mode parameter, preventing users from maintaining their current viewing mode (LIVE/PREVIEW_MODE/EDIT_MODE) when navigating in UVE. This fix preserves the mode parameter to ensure proper navigation between different view modes. - Removed deletion of mode parameter in createFullURL function - Updated test to expect mode parameter in generated URL Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Open
4 tasks
Open
4 tasks
zJaaal
requested review from
KevinDavilaDotCMS,
adrianjm-dotCMS,
dario-daza,
fmontes,
hmoreras,
nicobytes,
oidacra and
rjvelazco
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes UVE’s createFullURL helper so it preserves the mode query parameter, ensuring “Current View URL” navigation retains the user’s current viewing mode (LIVE / PREVIEW_MODE / EDIT_MODE).
Changes:
- Stop deleting
modefrom the params used to build the full URL increateFullURL. - Update the unit test expectation to include
mode=EDIT_MODEin the generated URL.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| core-web/libs/portlets/edit-ema/portlet/src/lib/utils/index.ts | Preserves mode when generating the “current view” URL so view mode is retained across navigation. |
| core-web/libs/portlets/edit-ema/portlet/src/lib/utils/utils.spec.ts | Updates createFullURL test to assert mode is present in the resulting URL. |
dario-daza
approved these changes
Feb 13, 2026
adrianjm-dotCMS
approved these changes
Feb 13, 2026
zJaaal
deleted the
34648-defect-uve-createfullurl-function-removes-mode-parameter-breaking-view-mode-navigation
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
createFullURLfunction in UVE which was incorrectly removing themodeparameter, preventing users from maintaining their current viewing mode (LIVE/PREVIEW_MODE/EDIT_MODE) when navigating or using buttons that rely on this URL.Changes
createFullURLfunction now preserves themodeparameter instead of deleting itmodeparameter in the generated URLWhy this matters
The
createFullURLfunction is intended to create a "CurrentViewURL" that preserves the user's current viewing context. By removing the mode parameter, users lost the ability to maintain their view mode when:Test plan
delete paramsCopy?.mode;line fromcreateFullURLfunctionRelated Issue
Fixes #34648
🤖 Generated with Claude Code
This PR fixes: #34648