Skip to content

Polars lazyframe pushdown fixes #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evertlammerts merged 1 commit into from
Feb 26, 2026
Merged

Polars lazyframe pushdown fixes #347

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions duckdb/polars_io.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,14 @@ def _pl_tree_to_sql(tree: _ExpressionTree) -> str:
)
return str(int_literal)

if node_type == "Float":
# Direct float literals
float_literal = tree[node_type]
assert isinstance(float_literal, (float, int, str)), (
f"The value of a Float should be a float, int or str but got {type(float_literal)}"
)
return str(float_literal)

if node_type == "Function":
# Handle boolean functions like IsNull, IsNotNull
func_tree = tree[node_type]
Expand Down Expand Up @@ -162,8 +170,8 @@ def _pl_tree_to_sql(tree: _ExpressionTree) -> str:
if node_type == "Cast":
cast_tree = tree[node_type]
assert isinstance(cast_tree, dict), f"A {node_type} should be a dict but got {type(cast_tree)}"
if cast_tree.get("options") != "NonStrict":
msg = f"Only NonStrict casts can be safely unwrapped, got {cast_tree.get('options')!r}"
if cast_tree.get("options") not in ("NonStrict", "Strict"):
msg = f"Only NonStrict/Strict casts can be safely unwrapped, got {cast_tree.get('options')!r}"
raise NotImplementedError(msg)
cast_expr = cast_tree["expr"]
assert isinstance(cast_expr, dict), f"A {node_type} should be a dict but got {type(cast_expr)}"
Expand Down
Loading