Skip to content

[doc] Theme generator Preview (Step 2)#2417

Merged
raquelarrojo merged 31 commits intotheme-generatorfrom
Mil4n0r/theme-generator-preview
Mar 9, 2026
Merged

[doc] Theme generator Preview (Step 2)#2417
raquelarrojo merged 31 commits intotheme-generatorfrom
Mil4n0r/theme-generator-preview

Conversation

@Mil4n0r
Copy link
Collaborator

@Mil4n0r Mil4n0r commented Mar 2, 2026

Checklist
(Check off all the items before submitting)

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Added step 2 for theme generator config.

Still need to address the issue with the layout for having scroll inside the preview area. The rest can be reviewed.

Merge step 1 first if possible.

@raquelarrojo raquelarrojo requested review from raquelarrojo and removed request for raquelarrojo March 3, 2026 08:05
@Mil4n0r Mil4n0r marked this pull request as ready for review March 5, 2026 15:11
@Mil4n0r Mil4n0r requested a review from raquelarrojo March 5, 2026 15:48
Copy link
Collaborator

@raquelarrojo raquelarrojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add some real context to the previews. Avoid "Label", "Sublabel", First step", "Second step" and give real values.

@Mil4n0r Mil4n0r changed the title Theme generator Preview (Step 2) [doc] Theme generator Preview (Step 2) Mar 6, 2026
@raquelarrojo raquelarrojo self-requested a review March 9, 2026 15:54
@raquelarrojo raquelarrojo merged commit 6e09f2e into theme-generator Mar 9, 2026
5 checks passed
@raquelarrojo raquelarrojo deleted the Mil4n0r/theme-generator-preview branch March 9, 2026 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants