Skip to content

[minor] Added inline styles for HalstackProvider #2421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Mil4n0r wants to merge 1 commit into from
Closed

[minor] Added inline styles for HalstackProvider #2421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions apps/website/screens/utilities/halstack-provider/HalstackProviderPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,19 @@ const sections = [
<td>Object with a given structure, specified below, for defining the opinionated theme.</td>
<td>-</td>
</tr>
<tr>
<td>
<DxcFlex direction="column" gap="var(--spacing-gap-xs)" alignItems="baseline">
<StatusBadge status="new" />
style
</DxcFlex>
</td>
<td>
<TableCode>React.CSSProperties</TableCode>
</td>
<td>CSS properties for styling the provider.</td>
<td>-</td>
</tr>
</tbody>
</DxcTable>
),
Expand Down
5 changes: 3 additions & 2 deletions packages/lib/src/HalstackContext.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ type HalstackProviderPropsType = {
labels?: DeepPartial<TranslatedLabels>;
children: ReactNode;
opinionatedTheme?: ThemeType;
style?: React.CSSProperties;
};

const HalstackThemed = styled.div<{ coreTheme?: ThemeType }>`
Expand Down Expand Up @@ -63,15 +64,15 @@ const createCoreTheme = (opinionatedTheme: ThemeType | undefined = {}) => {
return newTheme;
};

const HalstackProvider = ({ labels, children, opinionatedTheme }: HalstackProviderPropsType): JSX.Element => {
const HalstackProvider = ({ labels, children, opinionatedTheme, style }: HalstackProviderPropsType): JSX.Element => {
const parsedLabels = useMemo(() => (labels ? parseLabels(labels) : null), [labels]);
const parsedCoreTheme = useMemo(() => {
const theme = createCoreTheme(opinionatedTheme);
return theme;
}, [opinionatedTheme]);

return (
<HalstackThemed coreTheme={parsedCoreTheme}>
<HalstackThemed coreTheme={parsedCoreTheme} style={style}>
{parsedLabels ? (
<HalstackLanguageContext.Provider value={parsedLabels}>{children}</HalstackLanguageContext.Provider>
) : (
Expand Down