Conversation
* removed all references to `enabled` for parameters * ruff on tests
* Initial plan * Add GitHub Copilot instructions for EasyReflectometryLib Co-authored-by: rozyczko <8266281+rozyczko@users.noreply.github.com> * Address code review feedback for Copilot instructions Co-authored-by: rozyczko <8266281+rozyczko@users.noreply.github.com> * Fix formatting of myst_parser package name Co-authored-by: rozyczko <8266281+rozyczko@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: rozyczko <8266281+rozyczko@users.noreply.github.com>
* check the newest sphinx * try lines from doc_fix * no cairo on new runners. Switch to 2022. * install cairo * specify right path * install correct env * fixed notebooks * fixed magnetism * added id-token * added environment * test new_clear branch * update branch name and add cairo installation for new GH image * install pycairo before xhtml2pdf * typo * it's 1.16 and only on linux * it is svglib * revert cairo installation for the lib. * try with the master branch of corelib * fixed magnetism notebook
* initial commit of the refactored orso reader (model/data) * fix tests, refactor a bit * use orsopy resolve_to_layers() as default resolver * better Model instantiation * removed dead code * added orso_utils tests * ruff + missing test file * fixed missed file load
* minor fixes after recent changes in core
* fix for appending samples from loaded models * added unit tests * use most recent version of refl1d * update docs to include add_sample_from_orso * temporarily revert to fwhm * proper conversion from stack to layers. * fixed SLD read. * added handling for orso names (model and experiment) * model reindexing issue fixed. Project rst added * path for SLD-less orso files
* fix for appending samples from loaded models * added unit tests * use most recent version of refl1d * update docs to include add_sample_from_orso * temporarily revert to fwhm * minor fixes after CR + ruff format * back to pointwise * proper conversion from stack to layers. * added method * temporarily switch off pointwise * fixed SLD read. * added handling for orso names (model and experiment) * minor fix for names * CR review fixes * model reindexing issue fixed. Project rst added * path for SLD-less orso files * fix variances sent to bumps. Make FWHM default (temporarily) * fixed test to correspond to new resolution * added logs for changing minimizers * reload constraints where necessary * expose chi2 properly * PR review #1 * Fix the zero variances issue * allow 3.13 * added some tests
rozyczko
added
[scope] enhancement
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #295 +/- ##
=========================================
Coverage ? 88.16%
=========================================
Files ? 45
Lines ? 2620
Branches ? 315
=========================================
Hits ? 2310
Misses ? 238
Partials ? 72
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.