Fixes #1554 : Fixed by updating response in UserManagedCacheBuilder#3104
Open
Sandeep184299 wants to merge 1 commit intoehcache:masterfrom
Open
Fixes #1554 : Fixed by updating response in UserManagedCacheBuilder#3104Sandeep184299 wants to merge 1 commit intoehcache:masterfrom
Sandeep184299 wants to merge 1 commit intoehcache:masterfrom
Conversation
Sandeep184299
requested review from
AbfrmBlr,
chrisdennis,
jhouserizer and
kumarshilp
chrisdennis
requested changes
Jan 3, 2023
Member
chrisdennis
left a comment
chrisdennis
left a comment
There was a problem hiding this comment.
From what I can see here you've moved the logging from "builder build time" to "builder configuration time", and made it unconditional. It logs regardless of whether there is or isn't a serializer. I'm not sure how this could be considered a "fix" for this issue. The issue references not creating serializers that aren't needed... the logging in just a symptom of that issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.