Fixes #3169 : Avoid firing unneeded Events#3236
Open
SamuelBussmann wants to merge 8 commits intoehcache:masterfrom
Open
Fixes #3169 : Avoid firing unneeded Events#3236SamuelBussmann wants to merge 8 commits intoehcache:masterfrom
SamuelBussmann wants to merge 8 commits intoehcache:masterfrom
Conversation
Author
|
Can you retrigger the test pipelines? locally the test runs successful and it timed out on your infrastructure |
Author
|
Hello |
1b20dd0 to
0af1eb9
Compare
0af1eb9 to
248e59a
Compare
Fixes ehcache#3169 : Track event listeners keyed by type to allow earlier event firing veto ehcache#3170
…g listener Signed-off-by: Samuel Bussmann
…id submit delay Signed-off-by: Samuel Bussmann
Signed-off-by: Samuel Bussmann
Signed-off-by: Samuel Bussmann
Signed-off-by: Samuel Bussmann
Signed-off-by: Samuel Bussmann
Signed-off-by: Samuel Bussmann
c5c61b0 to
ae14b22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #3170 Track event listeners keyed by type to allow earlier event firing veto
This provides the following improvements:
Perf:
Testcase: 20k add(),get(),udate(),get(),remove() with a NoOp Listener on Removes
-> Baseline rev_ehcache=3.10.8
-> MR rev_ehcache =3.10_event-firing-veto