Send feedback on uninstall #2394
Open
+52
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vjr
reviewed
Jan 22, 2026
Member
|
What do you think about sending the signal directly in the flatpak backend? And eventually doing the same for installed? |
Member
Author
|
@leolost2605 yeah when I was doing this it felt extremely convoluted and messy. Do you want me to refactor first? |
leolost2605
reviewed
Jan 27, 2026
Member
leolost2605
left a comment
leolost2605
left a comment
There was a problem hiding this comment.
Should we maybe DRY this a bit? E.g. change the mainwindow.send_installed_toast to send_toast and have it take the performed package op as an argument. Then we could also unify the checking for the window active etc.
danirabbit
force-pushed
the
danirabbit/uninstall-feedback
branch
from
051eae8 to
32224ec
Compare
Fix notification body text DRY toast sending Add user feedback issue to appcenter metadata
danirabbit
force-pushed
the
danirabbit/uninstall-feedback
branch
from
32224ec to
f147f89
Compare
Member
Author
|
@leolost2605 fixed and proposed #2398 for merging after this with some more cleanup |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2393