Conversation
C++20 Concepts
Single particle QED emission
Issue at the south axis
Collaborator
Author
|
@alisagk could you add a comment in the main message on changes to GR axes bcs? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO
New features
Breaking changes
CMake3.5+ is now required (per 98669a2)API changes
[radiation]added to input substituting the previous[algorithms.synchrotron]etc.[species.cooling]is now[species.radiative_drag].traits::compatible_within PGen is nowarch::traits::pgen::compatible_with, imported from a header#include "archetypes/traits.h". All default pgens have been changed.Architectural changes
concept-s andrequires-clauses replace the sfinae tests C++20 Concepts #161plogandtoml11headers are now explicitly in theincludedirectory and are fixed fc13991.Coolingchanged toRadiativeDrag; now accepts multiple entries.PrtlPushersimilarly changed toParticlePusher; now accepts composition of different values.kernel::sr::Pusher_kernelis now cleaner accepting two auxiliary classes:PusherParams&PusherArrays.traits.hfiles.srpic.hppis now subdivided into different dedicated header files with explicit functions.Pusher_kernelnow accepts an additional template argument:class E = NoEmissionPolicy_t<SimEngine::SRPIC, M>.Bug fixes
[BUG] Memory allocation error from Kokkos random number generator #132(fixed in v1.3.3)FIXEDboundaries for fields now properly transform the passed field components from tetrad basis to code units (per 1d34ab9)Minor changes
-D TESTS=ONcan now be used together with pgen to also compile all unit tests.init_fldsis present in pgen (per f13a68d)stdc++fsnow only links with non-AppleClang compilers, since on Apple Clang it's linked by default, and will raise an error if linked explicitly.