Skip to content

Comments

fix(as5600): Fix missing espp/timer dependency in component manifest#600

Merged
finger563 merged 1 commit intomainfrom
fix/599-as5600-missing-timer-dep
Feb 19, 2026
Merged

fix(as5600): Fix missing espp/timer dependency in component manifest#600
finger563 merged 1 commit intomainfrom
fix/599-as5600-missing-timer-dep

Conversation

@finger563
Copy link
Contributor

Description

  • Add espp/timer dep to as5600 component manifest

Motivation and Context

Closes #599

How has this been tested?

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

Copilot AI review requested due to automatic review settings February 19, 2026 14:51
@finger563 finger563 self-assigned this Feb 19, 2026
@github-actions
Copy link

✅Static analysis result - no issues found! ✅

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the AS5600 component’s ESP-IDF Component Manager manifest so that projects depending on espp/as5600 also pull in the missing espp/timer component required for builds to succeed (per issue #599).

Changes:

  • Add espp/timer to components/as5600/idf_component.yml dependencies.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@finger563 finger563 merged commit 94696fb into main Feb 19, 2026
15 of 16 checks passed
@finger563 finger563 deleted the fix/599-as5600-missing-timer-dep branch February 19, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AS5600 component depends on espp/timer but does not declare the dependency

1 participant