Open
Conversation
|
Hi @liyanchang, thank you for your work on this project. I am trying to use this PR for one of the project that i am working on, and it seems to be working fine as expected. 🎉 one thing that I think might be useful for future is to be able to configure the PreserveInitialism with list of initialism instead of preserving all uppercase letters, but that is not a blocker (atleast for me) at the moment. do you think we can merge this PR anytime soon? thanks |
This was referenced Dec 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this fix or improve?
Here we preserve existing initialisms without them needing to be defined ahead of time.
For instance,
This is a possible solution to #8
Is this a breaking change API change or change in behavior?
This will not break or change any existing behavior.*
This does increase the API surface area so I'll let this one sit for a bit before committing to it.
Checklist:
I will likely not merge this for a bit to allow for feedback and also to get more comfortable with the API changes.