fix(jq): prevent process env pollution in jq builtin#452
Merged
Conversation
chaliy
force-pushed
the
claude/fix-410-Y2nIj
branch
from
38a7b32 to
0612557
Compare
Replace std::env::set_var() calls with a custom env implementation that passes shell variables to jaq via a global variable ($__bashkit_env__). The `env` filter is overridden with `def env: $__bashkit_env__;` which reads from the injected object instead of the process environment. This fixes three issues (TM-INF-013): - Thread-unsafe: set_var is unsound in multi-threaded contexts - Info leak: host process env vars were visible to jq's env filter - Race condition: concurrent jq calls could corrupt each other's env https://claude.ai/code/session_01WZjYqxm5xMPAEe7FSHJkDy
chaliy
force-pushed
the
claude/fix-410-Y2nIj
branch
from
0612557 to
33590cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
std::env::set_var()calls with a custom env implementation that reads fromctx.env/ctx.variablesdirectlyCloses #410
Test plan
cargo test --all-featurespasses (1451+ tests)cargo clippyandcargo fmtpass