fix(fs): use combined usage for OverlayFs write limits#458
Merged
Conversation
check_write_limits() was checking only upper-layer usage against limits. If the lower layer had 80MB and the combined limit was 100MB, the upper layer was allowed another full 100MB. Now uses compute_usage() to check against combined upper+lower usage. Closes #419
chaliy
force-pushed
the
claude/fix-419-Y2nIj
branch
from
3232cb4 to
7a3c083
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
check_write_limits()was checking only upper-layer usage against limitscompute_usage()to check against combined upper+lower usageTest plan
test_write_limits_include_lower_layer- write rejected when combined usage exceeds limittest_file_count_limit_includes_lower- file count limit includes lower layer filesCloses #419