fix(fs): add validate_path to all InMemoryFs methods#460
Merged
Conversation
Previously only read_file, write_file, append_file, mkdir had path validation. Now remove, stat, read_dir, exists, rename, copy, symlink, read_link, chmod all validate. copy() also checks write limits before creating entries. Closes #421 https://claude.ai/code/session_01WZjYqxm5xMPAEe7FSHJkDy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validate_path()calls to: remove, stat, read_dir, exists, rename, copy, symlink, read_link, chmodcopy()now also checks write limits before creating entriesTest plan
test_validate_path_on_copy— deep path rejectedtest_validate_path_on_rename— deep path rejectedtest_copy_respects_write_limits— file count limit enforcedtest_validate_path_on_chmod— deep path rejectedCloses #421