fix(tool): preserve custom builtins across create_bash calls#461
Merged
Conversation
std::mem::take emptied builtins on first use. Switch to Arc<dyn Builtin> so builtins are cloned (via Arc) on each create_bash call. Add Builtin impl for Arc<dyn Builtin> to enable Box wrapping. Closes #422 https://claude.ai/code/session_01WZjYqxm5xMPAEe7FSHJkDy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BashTool.builtinsfromVec<(String, Box<dyn Builtin>)>toVec<(String, Arc<dyn Builtin>)>create_bash()now clones Arc refs instead ofstd::mem::takewhich emptied builtinsBuiltinimpl forArc<dyn Builtin>to enable Box wrappingTest plan
test_create_bash_preserves_builtins— custom builtin available on second callCloses #422