fix(git): validate branch names to prevent path injection#462
Merged
Conversation
branch_create, branch_delete, checkout now validate ref names against git ref rules: no .., no control chars, no trailing .lock, no leading dots or dashes. Prevents overwriting .git/config via branch names. Closes #423 https://claude.ai/code/session_01WZjYqxm5xMPAEe7FSHJkDy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validate_ref_name()to reject.., control chars, trailing.lock, leading dots/dashesbranch_create,branch_delete, andcheckoutbranch_create("../../config")from overwriting.git/configTest plan
test_validate_ref_name_blocks_traversal—../../configrejectedtest_validate_ref_name_blocks_invalid— empty,.hidden,.lock,-dash, spaces, nulltest_validate_ref_name_allows_valid—main,feature/branch,fix-123,v1.0test_branch_create_rejects_traversal— integration testCloses #423