fix(builtins): handle multi-byte UTF-8 in tr expand_char_set()#468
Merged
fix(builtins): handle multi-byte UTF-8 in tr expand_char_set()#468
Conversation
Rewrite expand_char_set() to use char-based iteration instead of byte-based. The old code used spec.as_bytes() and `bytes[i] as char` which corrupted multi-byte UTF-8 characters. Closes #436
chaliy
force-pushed
the
claude/fix-436-Y2nIj
branch
from
e29bcd9 to
9e4ff61
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
expand_char_set()usedspec.as_bytes()andbytes[i] as charwhich corrupted multi-byte UTF-8Vec<char>indexingTest plan
test_tr_multibyte_utf8test_tr_multibyte_utf8_rangetest_cut_multibyte_utf8_charstest_expand_char_set_multibyteCloses #436