fix(network): use try_from instead of truncating u64-to-usize cast#472
Merged
fix(network): use try_from instead of truncating u64-to-usize cast#472
Conversation
Replace `u64 as usize` casts with `usize::try_from().unwrap_or(usize::MAX)` in network client (content_length) and Python bindings (limits). Prevents silent truncation on 32-bit platforms. Closes #430
chaliy
force-pushed
the
claude/fix-430-Y2nIj
branch
from
1898b4d to
aaa0a95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
content_length as usizeand limit casts silently truncate on 32-bit platformsusize::try_from().unwrap_or(usize::MAX)for safe saturationTest plan
test_u64_to_usize_no_truncationCloses #430