fix(builtins): make exported variables visible to Python's os.getenv#486
Merged
fix(builtins): make exported variables visible to Python's os.getenv#486
Conversation
Merge ctx.variables into env when running Python code so that variables set via `export VAR=val` are visible to os.getenv(). Also unskip two Python spec tests that now pass (getenv, nested dict access). Closes #316 https://claude.ai/code/session_01WZjYqxm5xMPAEe7FSHJkDy
93f107b to
05afc35
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ctx.variablesinto env when running Python code soexport VAR=valis visible toos.getenv()python3_vfs_getenvandpython3_nested_dict_accessCloses #316
Test plan