fix(ci): gate python behind feature flag for crates.io publish#512
Merged
fix(ci): gate python behind feature flag for crates.io publish#512
Conversation
Allow re-triggering the Publish workflow when bashkit is already on crates.io but bashkit-cli still needs publishing. https://claude.ai/code/session_01Jbg7Tuui72STWrJTfCLgWK
… publish Move python from a hardcoded dependency feature to a bashkit-cli feature flag (default = on). Code gated with #[cfg(feature = "python")] so bashkit-cli compiles when bashkit's python feature is unavailable (monty is git-only, stripped during crates.io publish). https://claude.ai/code/session_01Jbg7Tuui72STWrJTfCLgWK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bashkit-cliv0.1.9 publish to crates.io that failed becausebuilder.python()doesn't exist when bashkit'spythonfeature is stripped (monty is git-only)pythonfrom hardcoded dependency feature to a bashkit-cli feature flag (default = ["python"])#[cfg(feature = "python")]so it compiles without the featureTest plan
cargo build -p bashkit-cli(with python) passescargo build -p bashkit-cli --no-default-features(without python) passescargo test -p bashkit-cli --all-features— 9 tests passcargo test -p bashkit-cli --no-default-features— 7 tests pass (python tests skipped)cargo clippy --all-targets --all-featurespasses