.github/workflows: Migrate workflows to Blacksmith runners#3035
.github/workflows: Migrate workflows to Blacksmith runners#3035blacksmith-sh[bot] wants to merge 4 commits intomainfrom
Conversation
|
The latest Buf updates on your PR. Results from workflow CI / buf-check (pull_request).
|
| - name: Set up Docker Buildx | ||
| uses: docker/setup-buildx-action@v3 | ||
| - name: Setup Blacksmith Builder | ||
| uses: useblacksmith/setup-docker-builder@v1 |
Check warning
Code scanning / CodeQL
Unpinned tag for a non-immutable Action in workflow Medium
|
|
||
| - name: Build and push ${{ matrix.app.name }} Docker image | ||
| uses: docker/build-push-action@v6 | ||
| uses: useblacksmith/build-push-action@v2 |
Check warning
Code scanning / CodeQL
Unpinned tag for a non-immutable Action in workflow Medium
| - name: Set up Docker Buildx | ||
| uses: docker/setup-buildx-action@v3 | ||
| - name: Setup Blacksmith Builder | ||
| uses: useblacksmith/setup-docker-builder@v1 |
Check warning
Code scanning / CodeQL
Unpinned tag for a non-immutable Action in workflow Medium
|
|
||
| - name: Build and push Docker image | ||
| uses: docker/build-push-action@v6 | ||
| uses: useblacksmith/build-push-action@v2 |
Check warning
Code scanning / CodeQL
Unpinned tag for a non-immutable Action in workflow Medium
| - name: Set up Docker Buildx | ||
| uses: docker/setup-buildx-action@v3 | ||
| - name: Setup Blacksmith Builder | ||
| uses: useblacksmith/setup-docker-builder@v1 |
Check warning
Code scanning / CodeQL
Unpinned tag for a non-immutable Action in workflow Medium test
| uses: useblacksmith/setup-docker-builder@v1 | ||
| - name: Build evstack:local-dev (cached) | ||
| uses: docker/build-push-action@v6 | ||
| uses: useblacksmith/build-push-action@v2 |
Check warning
Code scanning / CodeQL
Unpinned tag for a non-immutable Action in workflow Medium test
|
Claude finished @blacksmith-sh[bot]'s task in 1m 27s —— View job Code Review: Migrate workflows to Blacksmith runnersSummaryThis PR migrates GitHub Actions workflows to use Blacksmith's faster runners and optimized Docker layer caching. The migration affects 5 workflow files and introduces 6 unpinned third-party actions that GitHub Advanced Security has flagged. Detailed Review1. Security Issues (Critical)Unpinned Third-Party Actions GitHub Advanced Security correctly flagged 6 instances of unpinned Blacksmith actions. Using unpinned tags (like Files affected:
Recommendation: Pin all third-party actions to specific commit SHAs for supply chain security: # Instead of:
uses: useblacksmith/setup-docker-builder@v1
# Use:
uses: useblacksmith/setup-docker-builder@<commit-sha> # v1This is a best practice for production workflows to prevent against compromised action repositories. Note that GitHub's own actions ( 2. Workflow Changes AssessmentPositive Changes: ✅ Concurrency control added (
✅ Runner upgrades are consistent
✅ Docker action replacements are functional
Cache Strategy Change:
- cache-from: type=gha
- cache-to: type=gha,mode=maxAccording to the PR description, Blacksmith provides automatic cache handling that's "4x faster" and "colocated." However, this introduces a vendor lock-in concern:
3. Workflow Correctness✅ All workflows maintain functional equivalence:
✅ No breaking changes to workflow interfaces:
4. CI/CD Best PracticesWell Done:
Areas for Consideration:
5. Performance & Resource EfficiencyExpected improvements (per PR description):
Recommendation: Set up benchmarking to validate these claims:
Consider adding workflow run time reporting or dashboards to measure ROI. 6. Testing & Reliability✅ All CI checks passing:
✅ PR already approved by @tac0turtle
Final RecommendationOverall assessment: This is a reasonable infrastructure migration with measurable benefits, but has one critical security issue that should be addressed. Before merging:
After merging:
Approval status: Functionally sound, but security hardening needed for production readiness. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3035 +/- ##
=======================================
Coverage 55.38% 55.38%
=======================================
Files 117 117
Lines 11674 11674
=======================================
Hits 6466 6466
Misses 4483 4483
Partials 725 725
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
To whomever may be reviewing this PR,
Blacksmith is the fastest way to run your GitHub Actions.
What does this PR change?
This PR has been automatically generated by a team member in your GitHub organization using Blacksmith's Migration Wizard, or MigWiz for short. This PR changes the following:
runs-on: blacksmith-4vcpu-ubuntu-2204). Learn more about the different instances available to choose from.FAQ