Closed
Conversation
ArBridgeman
requested a deployment
to
manual-approval
GitHub Actions
Waiting
ArBridgeman
force-pushed
the
feature/output_yaml_values
branch
from
daee521 to
8fe80f2
Compare
ArBridgeman
requested a deployment
to
manual-approval
GitHub Actions
Waiting
ArBridgeman
changed the base branch from
main
to
documentation/676_move_and_improve_workflows
ArBridgeman
commented
Jan 27, 2026
exasol/toolbox/tools/template.py
Outdated
|
|
||
| # yaml uses a shorthand to identify "on" and "off" tags. | ||
| # for GitHub workflows, we do NOT want "on" replaced with "True". | ||
| for character in ["O", "o"]: |
Collaborator
Author
There was a problem hiding this comment.
We have to do custom overrides to prevent certain changes.
ArBridgeman
commented
Jan 27, 2026
| @@ -1,197 +1,189 @@ | |||
| name: Checks | |||
|
|
|||
| on: | |||
Collaborator
Author
There was a problem hiding this comment.
the extra whitespaces by default are gone. is it important to restore these?
ArBridgeman
commented
Jan 27, 2026
.github/workflows/checks.yml
Outdated
| name: Docs | ||
| needs: [ Version-Check ] | ||
| needs: | ||
| - Version-Check |
Collaborator
Author
There was a problem hiding this comment.
lists are broken into vertical splits
ArBridgeman
commented
Jan 27, 2026
.github/workflows/checks.yml
Outdated
| python-version: "3.10" | ||
| poetry-version: "2.3.0" | ||
| - name: Build Documentation | ||
| run: | |
Collaborator
Author
There was a problem hiding this comment.
this could be updated in the template to be 1 line
ArBridgeman
commented
Jan 27, 2026
ArBridgeman
commented
Jan 27, 2026
exasol/toolbox/tools/template.py
Outdated
| QUOTE_REGEX = re.compile(r"^(\d+\.\d+(\.\d+)?|[a-zA-Z]+-\d+\.\d+|0\d+)$") | ||
|
|
||
|
|
||
| def str_presenter(dumper, data): |
Collaborator
Author
There was a problem hiding this comment.
nicer to put all this render_template stuff in one module...& use render_template outside of it instead.
Base automatically changed from
documentation/676_move_and_improve_workflows
to
main
January 27, 2026 15:05
ArBridgeman
requested a deployment
to
manual-approval
GitHub Actions
Waiting
ArBridgeman
requested a deployment
to
manual-approval
GitHub Actions
Waiting
ArBridgeman
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
|
ArBridgeman
requested a deployment
to
manual-approval
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Note: If any of the items in the checklist are not relevant to your PR, just check the box.
For any Pull Request
Is the following correct:
When Changes Were Made
Did you:
When Preparing a Release
Have you: