Github actions fix: Have some output for errors#92
Open
abishekvashok wants to merge 1 commit intofacebook:mainfrom
Open
Github actions fix: Have some output for errors#92abishekvashok wants to merge 1 commit intofacebook:mainfrom
abishekvashok wants to merge 1 commit intofacebook:mainfrom
Conversation
SARIF expects some information about tooling when there are no issues, SAPP currently doesn't print any information and exits silently in case there are no issues after applying filters. Github Actions expects the output to conform to SARIF. Hence, return empty results list along with tooling information as expected by SARIF. Signed-off-by: Abishek V Ashok <abishekvashok@gmail.com>
facebook-github-bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
black .usort format .flake8pip install -r requirements-dev.txtand completed the following:./scripts/run-tests.shand made sure all tests are passingSummary
SARIF expects some information about tooling when there are no issues, SAPP currently doesn't print any information and exits silently in case there are no issues after applying filters.
Github Actions expects the output to conform to SARIF. Hence, return empty results list along with tooling information as expected by SARIF.
For reference, see: https://github.com/facebook/pysa-action/actions/runs/4534111680
is crashing.
Test Plan
Before
https://github.com/facebook/pysa-action/actions/runs/4534111680
After
Fixes possible errors from happening in Github workflows that make use of
sapp-actionorpysa-action