add line locator (to identify f0s and bws for cleaning)#2
Open
avivajpeyi wants to merge 3 commits intofarr:mainfrom
Open
add line locator (to identify f0s and bws for cleaning)#2avivajpeyi wants to merge 3 commits intofarr:mainfrom
avivajpeyi wants to merge 3 commits intofarr:mainfrom
Conversation
Author
Author
|
Hmmm in some cases i guess the line-cleaner didnt work so well... Im guessing the MCMC might not have converged or smth... Any tips @farr, before i start looking at trace plots?
|
Owner
|
Hi @avivajpeyi --- glad that you're looking into it! I have a few thoughts (before you go looking at trace plots):
Unfortunately, this will likely mean that at least some of the lines (e.g. 598-600) which aren't formally overlapping will still not be treatable with this simple model. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
















This is really neat repo, @farr ! Popped up when i was looking online for implementations for Lorentzian lines.
Id like to automate the process of determining the lines to be removed.
Following Gupta and Cornish '24, we can identify the locations of narrowband spectral lines using a running median of the periodogram.
Any frequency bins where the periodogram power exceeds the running median by a chosen threshold (e.g., a factor of 10) can be marked as narrowband lines.
These identified lines can then treated using your mcmc script :)