Update ngDrag to use $timeout to hook in with angular, instead of set…#264
Open
rsc092020 wants to merge 1 commit intofatlinesofcode:masterfrom
Open
Update ngDrag to use $timeout to hook in with angular, instead of set…#264rsc092020 wants to merge 1 commit intofatlinesofcode:masterfrom
rsc092020 wants to merge 1 commit intofatlinesofcode:masterfrom
Conversation
…Timeout setTimeout can cause issues in protractor, because protractor waits for $timeout's to resolve in waitForAngular(), but not setTimeout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…Timeout
setTimeout can cause issues in protractor, because protractor waits for $timeout's to resolve in waitForAngular(), but not setTimeout