fix(firebase_ui_auth): Catch sms code validation#482
fix(firebase_ui_auth): Catch sms code validation#482wer-mathurin wants to merge 2 commits intofirebase:mainfrom
Conversation
|
@russellwheatley But the way I've done it may need refactoring. Affecting a completer more than once does not smell well... This is a breaking change since the Completer must return a nullable value. |
|
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
|
@russellwheatley: Just ping to make sure this is not automagically close |
|
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
|
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
Description
This allow the user to pass an onError function when an error happen when validating the sms code
Related Issues
#481
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.melos run test:unit:alldoesn't fail).Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?