Enabled support for php 8.5 in github actions#1906
Conversation
|
it seems that not all of our dependencies are ready for 8.5 support:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 1.x #1906 +/- ##
==========================================
+ Coverage 83.39% 83.66% +0.26%
==========================================
Files 1041 1017 -24
Lines 37842 37268 -574
==========================================
- Hits 31560 31181 -379
+ Misses 6282 6087 -195
🚀 New features to boost your workflow:
|
|
Once halaxa/json-machine#127 is merged we can move forward with this one! |
|
https://github.com/halaxa/json-machine/blob/1.2.6/CHANGELOG.md Has been released with 8.5 support. Could you merge this please and publish a new release? This dependency is blocking me from upgrading my stack to 8.5. |
|
Hey @Buffele I'm thinking about brining basic support for 8.5 (meaning that composer wont block it) in next few days. So in other words those are still blockers:
@drupol how far is your PR bringing 8.5 from being merged to nixpgs? |
The PR is made since quite a while now... waiting for people to review it. Feel free to test it and provide some feedback. |
I'm more than happy to help in any way that is needed to get this one merged! To test this PR I just need to point my nix shell towards your fork and commit that brings 8.5? |
There are many ways to do that and this is a valid way to achieve this indeed. |
Thanks for your quick reply. Basic support is completely fine with me. As long as I can run composer install and bump the minimum php version without worries. Thanks! |
ed0c8df to
7465a19
Compare
756fa88 to
aeae651
Compare
- drop 8.2 from nix shell - added 8.5 from nixpkgs PR - updated php extension in nix pkgs - added composer build:docker script - added missing extensions to Dockerfile installation
Resolves: #1905
Change Log
Added
Fixed
Changed
Removed
Deprecated
Security