[Repo Assist] test: add Seq module coverage for 7 untested functions; fix pending Seq.tail test#244
Draft
github-actions[bot] wants to merge 2 commits intomasterfrom
Conversation
…oices, groupNeighboursBy, equalsWith; fix ptest for Seq.tail - Activate the long-pending ptest for Seq.tail on empty input: the test was broken because `Seq.tail []` returns a lazy seq and `|> ignore` never enumerates it. Fix by calling `|> Seq.toList |> ignore` so the ArgumentException is actually raised. - Add 11 new deterministic tests covering previously-untested Seq functions: Seq.span, Seq.groupNeighboursBy, Seq.catOptions, Seq.choice1s, Seq.choice2s, Seq.partitionChoices, and Seq.equalsWith. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This PR was created by Repo Assist, an automated AI assistant.
Summary
Improves test coverage for the
Seqmodule inSeqTests.fs:Fixes a broken pending test —
ptest "I should not be able to get the tail of a empty sequence"was using|> ignorewhich never enumerates the lazy sequence, so theArgumentExceptionwas never thrown and the test could never pass. Fixed by calling|> Seq.toList |> ignoreto actually iterate the sequence. The test is now a regulartestand passes.Adds 11 new tests covering previously-untested
Seqfunctions:Seq.spanSeq.groupNeighboursBySeq.catOptionsSeq.choice1sSeq.choice2sSeq.partitionChoicesSeq.equalsWithTest Status
✅
FSharpx.Collections.Tests: 721 passed, 5 skipped, 0 failedThe 5 skipped tests are all pre-existing
ptestentries for bugs tracked in open PRs (#233, #238) — unchanged from before this PR.Previously: 709 passed, 6 skipped (the Seq.tail ptest was one of those 6 and is now activated).