Skip to content

Chore/fs eslint#123

Merged
gallayl merged 8 commits intodevelopfrom
chore/fs-eslint
Mar 6, 2026
Merged

Chore/fs eslint#123
gallayl merged 8 commits intodevelopfrom
chore/fs-eslint

Conversation

@gallayl
Copy link
Collaborator

@gallayl gallayl commented Mar 6, 2026

⚙️ Summary

Add @furystack/eslint-plugin with strict linting rules and fix violations across the codebase.

  • Integrate recommendedStrict (all packages) and shadesStrict (frontend) ESLint configs
  • Add Disposable implementations to all frontend services with Cache instances
  • Add isDisposed guards to SessionService to prevent post-disposal state updates
  • Refactor navigation from raw window.history to LocationService.navigate()/replace()
  • Migrate tests to usingAsync() wrappers for proper resource cleanup
  • Upgrade all FuryStack packages and @types/node

@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2026

Bundle Report

Changes will increase total bundle size by 1.53kB (0.08%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
shades-showcase-app-esm 1.88MB 1.53kB (0.08%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: shades-showcase-app-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js -1 bytes 4.64kB -0.02%
assets/index-*.js 56 bytes 5.77kB 0.98%
assets/index-*.js 857 bytes 218.78kB 0.39%
assets/index-*.js 134 bytes 21.44kB 0.63%
assets/ai-*.js 142 bytes 9.61kB 1.5%
assets/app-*.js 37 bytes 8.22kB 0.45%
assets/config-*.js 95 bytes 1.97kB 5.06% ⚠️
assets/dashboards-*.js 101 bytes 2.12kB 5.01% ⚠️
assets/settings-*.js -101 bytes 3.58kB -2.74%
assets/drives-*.js 158 bytes 2.85kB 5.88% ⚠️
assets/users-*.js 91 bytes 2.0kB 4.75%
assets/route-*.js -36 bytes 1.75kB -2.01%

Files in assets/index-*.js:

  • ./src/components/generic-editor/index.tsx → Total Size: 5.84kB

  • ./src/components/generic-editor/generic-editor-service.ts → Total Size: 1.56kB

Files in assets/index-*.js:

  • ./src/services/ffprobe-service.ts → Total Size: 1.24kB

  • ./src/pages/files/monaco-file-editor.tsx → Total Size: 3.67kB

Files in assets/index-*.js:

  • ./src/navigate-to-route.ts → Total Size: 449 bytes

  • ./src/components/command-palette/command-providers/app-settings.tsx → Total Size: 1.26kB

  • ./src/pages/offline.tsx → Total Size: 1.14kB

  • ./src/components/generic-error.tsx → Total Size: 2.46kB

  • ./src/components/command-palette/command-providers/entities.tsx → Total Size: 3.79kB

Files in assets/index-*.js:

  • ./src/pages/chat/chat-intivation-service.ts → Total Size: 4.23kB

Files in assets/ai-*.js:

  • ./src/pages/ai/ai-model-service.tsx → Total Size: 1.05kB

  • ./src/pages/ai/ai-chat-service.ts → Total Size: 2.4kB

Files in assets/app-*.js:

  • ./src/pages/admin/app-settings.tsx → Total Size: 2.02kB

Files in assets/config-*.js:

  • ./src/services/config-service.ts → Total Size: 3.08kB

Files in assets/dashboards-*.js:

  • ./src/services/dashboards-service.ts → Total Size: 2.55kB

Files in assets/settings-*.js:

  • ./src/pages/user/settings.tsx → Total Size: 6.13kB

Files in assets/drives-*.js:

  • ./src/services/drives-service.ts → Total Size: 4.67kB

Files in assets/route-*.js:

  • ./src/components/route-index-page.tsx → Total Size: 2.92kB

@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2026

Codecov Report

❌ Patch coverage is 74.74747% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.15%. Comparing base (3892f41) to head (ab0150a).

Files with missing lines Patch % Lines
frontend/src/pages/user/settings.tsx 0.00% 9 Missing ⚠️
frontend/src/pages/chat/chat-intivation-service.ts 20.00% 4 Missing ⚠️
frontend/src/pages/ai/ai-chat-service.ts 25.00% 3 Missing ⚠️
frontend/src/services/ffprobe-service.ts 0.00% 3 Missing ⚠️
service/src/ffprobe-service.ts 25.00% 3 Missing ⚠️
frontend/src/pages/ai/ai-model-service.tsx 33.33% 2 Missing ⚠️
...omponents/generic-editor/generic-editor-service.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #123      +/-   ##
===========================================
+ Coverage    51.72%   52.15%   +0.43%     
===========================================
  Files          231      231              
  Lines         4404     4471      +67     
  Branches       778      788      +10     
===========================================
+ Hits          2278     2332      +54     
- Misses        1946     1959      +13     
  Partials       180      180              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gallayl gallayl merged commit 8dd8230 into develop Mar 6, 2026
11 of 13 checks passed
@gallayl gallayl deleted the chore/fs-eslint branch March 6, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants